Open
Conversation
Fixed filename error in instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates installation guidance and packaging configuration to fix confusing/outdated instructions. These were the edits I performed locally to successfully install
PharmaPyChanges
setup.pypy_modules=["PharmaPy"]so editable install resolves the package correctly.Extensionimport.install_instructions.txtpython setup.py developwithpip install -e ..-yfor conda requirements install.tests/integration:cd tests/integrationpython reactor_tests.pypython -c "import PharmaPy; print('PharmaPy import OK')".gitignoreMotivation
Validation
pharma-py) and installed dependencies fromrequirements.txt.tests/integration(reactor_tests.py, 2 tests passing).